Potting the cells has a lot of benefits. It increases energy density, mechanical reliability, decreases weight, increases impact protection, prevents water ingress, etc.
I don't think they're poorly constructed, but they are not designed for cell level repair, the are designed for maximum energy density in the smallest space/weight.
A lot of electric cars use cells that can be replaced, but noone I know is doing that. Teslas use repairable batteries, but I don't think they will replace a cell, they swap the whole pack. I'd be surprised if anyone swaps cells.
This is because cells and thus batteries age in complex and unpredictable ways. Adding a new cell would cause performance issues, over stressing the new cell because its impedance is lower, current draw is higher etc.You need every cell and group of cells to perform almost identically to have a good battery.
Used/bad cells/batteries have little to no value, and Zero has to pay to recycle them. It makes sense they wouldn't offer money for an old one. They're not huge either, so its not like they can afford to absorb the cost, or have a large pile of used but good batteries around.
Really this boils down to cost of the battery and longevity of the battery. Cost is high, so replacement is expensive. EV Batteries are built in clean rooms using extremely precise equipment, they're not easy to make. Scale will help with that, but its a very difficult problem. Zero, unlike Tesla, has to trade some longevity(better cooling/heating, extra cells, etc.) for weight and size. Treated right, a Zero battery should last more than 5 years, probably closer to 10. Some people here have seen that. But all batteries will experience some degradation and will eventually fail.
In short, electric motorcycles as a class are unlikely to be anywhere near the longevity of a gas bike{assuming you keep replacing parts} or an ice car. Until batteries improve or get significantly cheaper, that's the reality. The only question then is will the reduced cost of maintenance and electricity outweigh the longer lifespan, gas costs, and more expensive maintenance of an ice bike. I'll let someone else do that math, but the answer right now is probably it depends.